Summary: | [CMake][EFL] Put failure API test excutables into failure directory | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 132813 | ||||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-03-23 02:42:10 PDT
Created attachment 249229 [details]
Patch
Comment on attachment 249229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249229&action=review LGTM, r=me. > Tools/TestWebKitAPI/CMakeLists.txt:-220 > - set_target_properties(${testBaseName} PROPERTIES testBaseName was a typo here, wasn't it? Created attachment 249230 [details]
Patch
(In reply to comment #2) > Comment on attachment 249229 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249229&action=review > > LGTM, r=me. Additionally I remove unnecessary SHARED_CORE and comment for SeccompFilters test. Could you take a look again ? > > Tools/TestWebKitAPI/CMakeLists.txt:-220 > > - set_target_properties(${testBaseName} PROPERTIES > > testBaseName was a typo here, wasn't it? Yes, it was typo. Created attachment 249231 [details]
Patch
Comment on attachment 249231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249231&action=review > Tools/ChangeLog:9 > + Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. Does it mean that the seccomp test fails with and without SHARED_CORE on EFL? (In reply to comment #6) > Comment on attachment 249231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249231&action=review > > > Tools/ChangeLog:9 > > + Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. > > Does it mean that the seccomp test fails with and without SHARED_CORE on EFL? yes, as far as I know, SHARED_CORE is not needed to run API test on EFL. It was needed to run layout test, however we need the option no longer since r172894. (Developer mode). Created attachment 249232 [details]
Patch
Comment on attachment 249232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249232&action=review > Tools/TestWebKitAPI/PlatformEfl.cmake:-132 > -# are not (and should not) be exposed by default. We Symbol has been exposed since r172894. Thus SeccompFilters should not fail due to the SHARED_CORE. Comment on attachment 249232 [details]
Patch
Just a question: are there bug reports for the failing API tests and a meta bug to collect these bugs?
(In reply to comment #10) > Comment on attachment 249232 [details] > Patch > > Just a question: are there bug reports for the failing API tests and a meta > bug to collect these bugs? Yes, bug 132813 is to handle failure API test for EFL port. We have to maintain it as well. Bug 132813 - [EFL][WK2][Meta] Fix broken ewebkit2 API test cases Comment on attachment 249232 [details] Patch Clearing flags on attachment: 249232 Committed r181853: <http://trac.webkit.org/changeset/181853> All reviewed patches have been landed. Closing bug. |