| Summary: | [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 142938 | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2015-03-20 21:08:28 PDT
Created attachment 249162 [details]
Patch
Comment on attachment 249162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249162&action=review r=me. > Tools/DumpRenderTree/TestRunner.h:56 > + void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; } Should this be passed as a const reference? Or does C++ now know how to magically do a move here? (In reply to comment #2) > Comment on attachment 249162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249162&action=review > > r=me. > > > Tools/DumpRenderTree/TestRunner.h:56 > > + void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; } > > Should this be passed as a const reference? Or does C++ now know how to > magically do a move here? I'll sprinkle on a little WTF::move. Thanks! Committed r182017: <http://trac.webkit.org/changeset/182017> |