Bug 142931 – [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers

[Jer Noble]

Created attachment 249162 [details]
Patch

[Brent Fulgham]

Comment on attachment 249162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249162&action=review

r=me.

> Tools/DumpRenderTree/TestRunner.h:56
> +    void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; }

Should this be passed as a const reference? Or does C++ now know how to magically do a move here?

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 249162 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249162&action=review
> 
> r=me.
> 
> > Tools/DumpRenderTree/TestRunner.h:56
> > +    void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; }
> 
> Should this be passed as a const reference? Or does C++ now know how to
> magically do a move here?

I'll sprinkle on a little WTF::move. Thanks!

[Jer Noble]

Committed r182017: <http://trac.webkit.org/changeset/182017>