Bug 142927

Summary: Remove the prefix for CSS Transforms
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142935    
Bug Blocks:    
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch
none
Patch
none
Patch
none
Patch none

Description Dean Jackson 2015-03-20 16:35:40 PDT 
It's 2015. The time has come to remove the -webkit prefix from the CSS transform properties:

- transform
- transform-origin
- transform-style
- perspective
- perspective-origin

For transform-style, we'll keep the older property around as well, so that if we change behaviour we can detect legacy content.
Comment 1 Dean Jackson 2015-03-20 16:35:55 PDT 
<rdar://problem/11568151>
Comment 2 Dean Jackson 2015-03-20 16:57:05 PDT 
Created attachment 249148 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-03-20 17:12:21 PDT 
Comment on attachment 249148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249148&action=review

> LayoutTests/transforms/2d/transform-2d-prefixed.html:2
> +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
> +   "http://www.w3.org/TR/html4/loose.dtd">

<!DOCTYPE html>

> LayoutTests/transforms/2d/transform-2d-prefixed.html:4
> +<html lang="en">

no lang

> LayoutTests/transforms/2d/transform-2d-prefixed.html:6
> +  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

remove
Comment 4 Dean Jackson 2015-03-20 17:41:25 PDT 
Created attachment 249153 [details]
Patch
Comment 5 Dean Jackson 2015-03-20 23:07:33 PDT 
Created attachment 249163 [details]
Patch
Comment 6 Dean Jackson 2015-03-20 23:20:00 PDT 
Created attachment 249164 [details]
Patch
Comment 7 Dean Jackson 2015-03-20 23:55:07 PDT 
Committed r181824: <http://trac.webkit.org/changeset/181824>
Comment 9 WebKit Commit Bot 2015-03-21 00:27:49 PDT 
Re-opened since this is blocked by bug 142935
Comment 10 Alexey Proskuryakov 2015-03-21 00:41:37 PDT 
Comment on attachment 249164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249164&action=review

> Source/WebCore/css/CSSPropertyNames.in:618
> +# Keeping -webkit-transform-style around is how we'll detect legacy content. At that point
> +# we'll have to add a custom builder and a new ETransformStyle3D type.

I suspect that it could be due to these comments - this file uses C++ style comments elsewhere.
Comment 11 Dean Jackson 2015-03-21 21:33:20 PDT 
Created attachment 249190 [details]
Patch
Comment 12 Dean Jackson 2015-03-21 21:56:36 PDT 
Committed r181832: <http://trac.webkit.org/changeset/181832>