Bug 142927

Summary:

Remove the prefix for CSS Transforms

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

142935

Bug Blocks:

Attachments:

Description	Flags
Patch	simon.fraser: review+
Patch	none
Patch	none
Patch	none
Patch	none

Dean Jackson

Reported 2015-03-20 16:35:40 PDT

It's 2015. The time has come to remove the -webkit prefix from the CSS transform properties: - transform - transform-origin - transform-style - perspective - perspective-origin For transform-style, we'll keep the older property around as well, so that if we change behaviour we can detect legacy content.

Attachments
Patch (90.92 KB, patch) 2015-03-20 16:57 PDT, Dean Jackson	simon.fraser: review+	Details Formatted Diff Diff
Patch (92.89 KB, patch) 2015-03-20 17:41 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (98.43 KB, patch) 2015-03-20 23:07 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (98.87 KB, patch) 2015-03-20 23:20 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (98.89 KB, patch) 2015-03-21 21:33 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2015-03-20 16:35:55 PDT

<rdar://problem/11568151>

Dean Jackson

Comment 2 2015-03-20 16:57:05 PDT

Created attachment 249148 [details] Patch

Simon Fraser (smfr)

Comment 3 2015-03-20 17:12:21 PDT

Comment on attachment 249148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249148&action=review > LayoutTests/transforms/2d/transform-2d-prefixed.html:2 > +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" > + "http://www.w3.org/TR/html4/loose.dtd"> <!DOCTYPE html> > LayoutTests/transforms/2d/transform-2d-prefixed.html:4 > +<html lang="en"> no lang > LayoutTests/transforms/2d/transform-2d-prefixed.html:6 > + <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> remove

Dean Jackson

Comment 4 2015-03-20 17:41:25 PDT

Created attachment 249153 [details] Patch

Dean Jackson

Comment 5 2015-03-20 23:07:33 PDT

Created attachment 249163 [details] Patch

Dean Jackson

Comment 6 2015-03-20 23:20:00 PDT

Created attachment 249164 [details] Patch

Dean Jackson

Comment 7 2015-03-20 23:55:07 PDT

Committed r181824: <http://trac.webkit.org/changeset/181824>

Alexey Proskuryakov

Comment 8 2015-03-21 00:25:10 PDT

This broke Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/68556/steps/compile-webkit/logs/stdio

WebKit Commit Bot

Comment 9 2015-03-21 00:27:49 PDT

Re-opened since this is blocked by bug 142935

Alexey Proskuryakov

Comment 10 2015-03-21 00:41:37 PDT

Comment on attachment 249164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249164&action=review > Source/WebCore/css/CSSPropertyNames.in:618 > +# Keeping -webkit-transform-style around is how we'll detect legacy content. At that point > +# we'll have to add a custom builder and a new ETransformStyle3D type. I suspect that it could be due to these comments - this file uses C++ style comments elsewhere.

Dean Jackson

Comment 11 2015-03-21 21:33:20 PDT

Created attachment 249190 [details] Patch

Dean Jackson

Comment 12 2015-03-21 21:56:36 PDT

Committed r181832: <http://trac.webkit.org/changeset/181832>

Note You need to log in before you can comment on or make changes to this bug.