Bug 142904

Summary: [Content Filtering] Adopt NEFilterSource unblock handling
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128858    
Attachments:
Description Flags
Patch kling: review+

Andy Estes
Reported 2015-03-20 01:53:38 PDT
[Content Filtering] Adopt NEFilterSource unblock handling
Attachments
Patch (2.94 KB, patch)
2015-03-20 02:03 PDT, Andy Estes 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-03-20 02:03:36 PDT
Created attachment 249099 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-20 02:04:55 PDT
Attachment 249099 [details] did not pass style-queue: ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:169: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:170: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 3 2015-03-20 02:05:43 PDT
rdar://problem/19158925
Andreas Kling
Comment 4 2015-03-20 02:12:03 PDT
Comment on attachment 249099 [details] Patch r=me
Andy Estes
Comment 5 2015-03-20 02:37:07 PDT
Committed r181795: <http://trac.webkit.org/changeset/181795>
Note You need to log in before you can comment on or make changes to this bug.