Bug 142889

Summary:

[Mac] Move MediaPlaybackTargetPicker

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Eric Carlson 2015-03-19 18:31:37 PDT

Move WebMediaPlaybackTargetPickerMacProxy.* to WebCore so the classes can be used by both WK1 and WK2.

Comment 1 Eric Carlson 2015-03-19 18:39:43 PDT

Created attachment 249075 [details]
Proposed patch

Comment 2 Tim Horton 2015-03-19 18:49:14 PDT

Comment on attachment 249075 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249075&action=review

> Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:31
> +#include <wtf/RefCounted.h>

why?

> Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:32
> +#include <wtf/RefPtr.h>

why?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:103
> +    m_deviceChangeTimer.stop();
> +    m_deviceChangeTimer.startOneShot(0);

are both of these necessary?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:112
> +        [m_devicePickerMenuController.get() addObserver:m_devicePickerMenuControllerDelegate.get() forKeyPath:externalOutputDeviceAvailableKeyName options:NSKeyValueObservingOptionNew context:nullptr];

no .get()s throughout here.

Comment 3 Eric Carlson 2015-03-19 20:53:28 PDT

Committed r181777: http://trac.webkit.org/changeset/181777