Bug 142889

Summary: [Mac] Move MediaPlaybackTargetPicker
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2015-03-19 18:31:37 PDT
Move WebMediaPlaybackTargetPickerMacProxy.* to WebCore so the classes can be used by both WK1 and WK2.
Attachments
Proposed patch (66.75 KB, patch)
2015-03-19 18:39 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-03-19 18:39:43 PDT
Created attachment 249075 [details] Proposed patch
Tim Horton
Comment 2 2015-03-19 18:49:14 PDT
Comment on attachment 249075 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=249075&action=review > Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:31 > +#include <wtf/RefCounted.h> why? > Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:32 > +#include <wtf/RefPtr.h> why? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:103 > + m_deviceChangeTimer.stop(); > + m_deviceChangeTimer.startOneShot(0); are both of these necessary? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:112 > + [m_devicePickerMenuController.get() addObserver:m_devicePickerMenuControllerDelegate.get() forKeyPath:externalOutputDeviceAvailableKeyName options:NSKeyValueObservingOptionNew context:nullptr]; no .get()s throughout here.
Eric Carlson
Comment 3 2015-03-19 20:53:28 PDT
Committed r181777: http://trac.webkit.org/changeset/181777
Note You need to log in before you can comment on or make changes to this bug.