Bug 142876

Summary: [GTK] Search for the Wayland dependency when enabling Wayland target
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Zan Dobersek
Reported 2015-03-19 13:10:46 PDT
[GTK] Search for the Wayland dependency when enabling Wayland target
Attachments
Patch (1.26 KB, patch)
2015-03-19 13:12 PDT, Zan Dobersek 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-03-19 13:12:35 PDT
Created attachment 249054 [details] Patch
Martin Robinson
Comment 2 2015-03-19 13:20:23 PDT
Comment on attachment 249054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review > ChangeLog:9 > + requirement of either the GTK+ ord GDK pkg-config files, so we have to Nit: ord -> or > Source/cmake/OptionsGTK.cmake:82 > +if (ENABLE_WAYLAND_TARGET) > + find_package(Wayland REQUIRED) > +endif () > + Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well?
Zan Dobersek
Comment 3 2015-03-20 01:20:13 PDT
Comment on attachment 249054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review >> Source/cmake/OptionsGTK.cmake:82 >> + > > Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well? They're already listed in Source/WebCore/PlatformGTK.cmake.
Zan Dobersek
Comment 4 2015-03-20 02:24:19 PDT
Committed r181793: <http://trac.webkit.org/changeset/181793>
Note You need to log in before you can comment on or make changes to this bug.