| Summary: | [GTK] Search for the Wayland dependency when enabling Wayland target | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, mrobinson | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2015-03-19 13:10:46 PDT
Created attachment 249054 [details]
Patch
Comment on attachment 249054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review > ChangeLog:9 > + requirement of either the GTK+ ord GDK pkg-config files, so we have to Nit: ord -> or > Source/cmake/OptionsGTK.cmake:82 > +if (ENABLE_WAYLAND_TARGET) > + find_package(Wayland REQUIRED) > +endif () > + Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well? Comment on attachment 249054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review >> Source/cmake/OptionsGTK.cmake:82 >> + > > Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well? They're already listed in Source/WebCore/PlatformGTK.cmake. Committed r181793: <http://trac.webkit.org/changeset/181793> |