| Summary: | [GTK] Fix build break after r181720 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||
| Component: | WebKitGTK | Assignee: | Hunseop Jeong <hs85.jeong> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | clopez, commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, ossy, rego, sabouhallawa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 142805 | ||||||
| Attachments: |
|
||||||
Created attachment 249012 [details]
Patch
Comment on attachment 249012 [details]
Patch
It's not exactly related to GTK, but !ENABLE(CSS_IMAGE_RESOLUTION).
But the fix is correct, r=me.
already fixed by anyone else - http://trac.webkit.org/changeset/181729 Hunseop, please add a comment to the original bug too next time, because folks won't notice that somebody already fixed the build. (In reply to comment #4) > Hunseop, please add a comment to the original bug too next time, > because folks won't notice that somebody already fixed the build. And you can ask for review on #webkit immediately for important buildfix, feel free to ping the author and the reviewer of the original change or a random reviewer on #webkit, and then ask them to commit it too manually, it is much more faster than waiting for commit queue. |
../../Source/WebCore/rendering/RenderImage.cpp: In member function ‘virtual void WebCore::RenderImage::styleDidChange(WebCore::StyleDifference, const WebCore::RenderStyle*)’: ../../Source/WebCore/rendering/RenderImage.cpp:225:57: error: expected ‘)’ before ‘;’ token repaintOrMarkForLayout(ImageSizeChangeForAltText; Fix typo.