Bug 142849

Summary: [GTK] Fix inspector userinterface related incremental build issue
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, dbates, gyuyoung.kim, jh718.park, joepeck, mrobinson, nvasilyev, ossy, pnormand, rego
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-03-18 17:16:31 PDT
Nowadays the GTK buildbot and EWS fails regularly with an inspector userinterface related incremental build issue. The problem is that cmake should rerun to regenerate dependency when inspector userinterface changes, but it doesn't run. build error after r181704: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ScopeVariableTreeElement.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it build error after r181517: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it False positive incrementail build issues which needs manual fix by bot maintainers can be annoying and we should avoid them. I think we should simply rereun cmake always when this directory changes.
Attachments
Patch (1.21 KB, patch)
2015-03-18 17:18 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2015-03-18 23:37 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-03-18 17:18:00 PDT
Created attachment 248991 [details] Patch
Csaba Osztrogonác
Comment 2 2015-03-18 23:22:35 PDT
GTK bots and EWS are stucked again due to this bug: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it
Csaba Osztrogonác
Comment 3 2015-03-18 23:25:42 PDT
(note: r162545 used this idea for Options<EFL|GTK>.cmake and OptionsCommon.cmake)
Csaba Osztrogonác
Comment 4 2015-03-18 23:37:52 PDT
Created attachment 249020 [details] Patch with reverting the previous whitespace workaround
Carlos Garcia Campos
Comment 5 2015-03-19 00:35:42 PDT
Comment on attachment 249020 [details] Patch Let's try this way, thanks ossy!
WebKit Commit Bot
Comment 6 2015-03-19 01:19:57 PDT
Comment on attachment 249020 [details] Patch Clearing flags on attachment: 249020 Committed r181735: <http://trac.webkit.org/changeset/181735>
WebKit Commit Bot
Comment 7 2015-03-19 01:20:01 PDT
All reviewed patches have been landed. Closing bug.
Joonghun Park
Comment 8 2015-03-25 01:34:05 PDT
I think there is an insignificant variable name typo in this patch. inspectorUserInterfaceDircetory -> inspectorUserInterfaceDirectory.
Note You need to log in before you can comment on or make changes to this bug.