Bug 142847

Summary:

Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Unpaused debugger hides header, etc	none
[SCREENSHOT] 1. default sidebar view	none
[SCREENSHOT] 2. paused view	none
[SCREENSHOT] 3. paused view with collapsed script content	none
[SCREENSHOT] 4. resumed with collapsing being ignored	none
show only enabled Breakpoints	none

Description Jonathan Wells 2015-03-18 16:54:27 PDT

When the debugger is paused, only then would the section with scripts and breakpoints need a header, which should just say "Scripts" at this point since scripts without breakpoints show as well, and because other information aside from just breakpoints is planned for the future.

Comment 1 Jonathan Wells 2015-03-18 18:03:19 PDT

Created attachment 248999 [details]
[PATCH] Unpaused debugger hides header, etc

Comment 2 Jonathan Wells 2015-03-18 18:19:20 PDT

Created attachment 249000 [details]
[SCREENSHOT] 1. default sidebar view

Comment 3 Jonathan Wells 2015-03-18 18:19:43 PDT

Created attachment 249001 [details]
[SCREENSHOT] 2. paused view

Comment 4 Jonathan Wells 2015-03-18 18:20:05 PDT

Created attachment 249002 [details]
[SCREENSHOT] 3. paused view with collapsed script content

Comment 5 Jonathan Wells 2015-03-18 18:20:31 PDT

Created attachment 249004 [details]
[SCREENSHOT] 4. resumed with collapsing being ignored

Comment 6 Tobias Reiss 2015-03-19 01:14:48 PDT

Created attachment 249024 [details]
show only enabled Breakpoints

Re: Screenshot 1-4

I like the "Scripts" header and I would even rename the placeholder in the search bar from "Filter Breakpoint list" to "Filter Scripts list" because it looks like you're not just filtering files that contain Breakpoints.

What I'm missing is a quick way of removing all Breakpoints and a list of Breakpoints. But I'm not sure how strong I actually miss that feature. In case you want to spend more time on that I would propose adding a checkbox "Only show enabled Breakpoints" or a Button á la Xcode next to the search bar (See Screenshot).

Comment 7 Timothy Hatcher 2015-03-19 16:04:41 PDT

We could maybe the filter button a tri-state. All scripts with breakpoints, all scripts with enabled breakpoints, off (all scripts).

Comment 8 Timothy Hatcher 2015-03-19 16:06:22 PDT

Comment on attachment 248999 [details]
[PATCH] Unpaused debugger hides header, etc

You will want to update the filter placeholder. See line 111.

Comment 9 WebKit Commit Bot 2015-03-19 16:52:51 PDT

Comment on attachment 248999 [details]
[PATCH] Unpaused debugger hides header, etc

Clearing flags on attachment: 248999

Committed r181768: <http://trac.webkit.org/changeset/181768>

Comment 10 WebKit Commit Bot 2015-03-19 16:52:54 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 Jonathan Wells 2015-03-23 15:23:50 PDT

<rdar://problem/20266212>