| Summary: | Web Inspector: Debugger Popovers and Probes should use FormattedValue/ObjectTreeView instead of Custom/ObjectPropertiesSection | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | burg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 248949 [details]
[PATCH] Proposed Fix
Created attachment 248950 [details]
[IMAGE] Before
Created attachment 248951 [details]
[IMAGE] After
*** Bug 131081 has been marked as a duplicate of this bug. *** Comment on attachment 248949 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=248949&action=review > Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGridNode.js:89 > - if (sample instanceof WebInspector.RemoteObject) { > - switch (sample.type) { > - case "function": // FIXME: is there a better way to visualize functions? > - case "object": > - return new WebInspector.ObjectPropertiesSection(sample, WebInspector.ProbeSet.SampleObjectTitle).element; > - case "string": > - case "number": > - case "boolean": > - case "undefined": > - case "null": > - return document.createTextNode(sample.value); > - case "array": > - // FIXME: reuse existing visualization of arrays here. > - default: console.log("Don't know how to represent sample:", sample); > - } > - } > + if (sample instanceof WebInspector.RemoteObject) > + return WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject(sample, null); Beautiful! |
* SUMMARY Debugger Popovers and Probes should use FormattedValue/ObjectTreeView instead of Custom/ObjectPropertiesSection. Debugger Popovers: - attempt to replicate FormattedValue for primitives => FormattedValue - uses ObjectPropertiesSection for objects => ObjectTree properties only Probes: - don't style primitives => FormattedValue - uses ObjectPropertiesSection for objects => ObjectTree - doesn't have previews => give previews! These are easy conversions.