Bug 142830 – Web Inspector: Debugger Popovers and Probes should use FormattedValue/ObjectTreeView instead of Custom/ObjectPropertiesSection

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Debugger Popovers and Probes should use FormattedValue/ObjectTreeView instead of Custom/ObjectPropertiesSection.

    Debugger Popovers:
      - attempt to replicate FormattedValue for primitives => FormattedValue
      - uses ObjectPropertiesSection for objects => ObjectTree properties only

    Probes:
      - don't style primitives => FormattedValue
      - uses ObjectPropertiesSection for objects => ObjectTree
      - doesn't have previews => give previews!

These are easy conversions.

[Joseph Pecoraro]

Created attachment 248949 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 248950 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 248951 [details]
[IMAGE] After

[Joseph Pecoraro]

*** Bug 131081 has been marked as a duplicate of this bug. ***

[Timothy Hatcher]

Comment on attachment 248949 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=248949&action=review

> Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGridNode.js:89
> -        if (sample instanceof WebInspector.RemoteObject) {
> -            switch (sample.type) {
> -            case "function": // FIXME: is there a better way to visualize functions?
> -            case "object":
> -                return new WebInspector.ObjectPropertiesSection(sample, WebInspector.ProbeSet.SampleObjectTitle).element;
> -            case "string":
> -            case "number":
> -            case "boolean":
> -            case "undefined":
> -            case "null":
> -                return document.createTextNode(sample.value);
> -            case "array":
> -            // FIXME: reuse existing visualization of arrays here.
> -            default: console.log("Don't know how to represent sample:", sample);
> -            }
> -        }
> +        if (sample instanceof WebInspector.RemoteObject)
> +            return WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject(sample, null);

Beautiful!

[Joseph Pecoraro]

http://trac.webkit.org/changeset/181722