| Summary: | Simple line layout: Use Vector<>::const_iterator instead of custom FlowContents::Iterator. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 142812 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2015-03-17 19:40:35 PDT
Created attachment 248903 [details]
Patch
Created attachment 248904 [details]
Patch
Comment on attachment 248904 [details] Patch Rejecting attachment 248904 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 248904, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: eded at 1 with fuzz 3. patching file Source/WebCore/rendering/SimpleLineLayoutFlowContents.h Hunk #1 succeeded at 46 with fuzz 2. Hunk #2 FAILED at 58. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/SimpleLineLayoutFlowContents.h.rej patching file Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5058877351526400 Created attachment 248905 [details]
Patch
Comment on attachment 248905 [details] Patch Clearing flags on attachment: 248905 Committed r181683: <http://trac.webkit.org/changeset/181683> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 142812 This patch depends on <http://trac.webkit.org/changeset/181667>, so it had to be reverted too. I am not aware of any problems with it per se. Committed r181698: <http://trac.webkit.org/changeset/181698> |