| Summary: | Make it possible to compute a region for elements on the page that have wheel event handlers | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ap, bfulgham, buildbot, cmarcelo, commit-queue, esprehn+autocc, glenn, hyatt, jamesr, jason.davies, jonlee, kangil.han, kondapallykalyan, luiz, rniwa, sam, simon.fraser, tonikitoo, webkit-bug-importer, WebkitBugTracker, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2015-03-17 17:56:42 PDT
Created attachment 248894 [details]
Patch
Comment on attachment 248894 [details] Patch Attachment 248894 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4871917962002432 New failing tests: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html Created attachment 248902 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 248963 [details]
Patch
Comment on attachment 248963 [details] Patch Attachment 248963 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4904563471548416 New failing tests: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll.html Created attachment 248967 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 248963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248963&action=review r=me > Source/WebCore/dom/Document.cpp:6118 > + return renderView->documentRect(); Note that documentRect() does apply a transform. I don't know if you really wanted unscaledDocumentRect() here or not. I'm not sure. > Source/WebCore/dom/Element.cpp:957 > +LayoutRect Element::eventBounds(bool& boundsIncludeAllDescendantElements, bool& includesFixedPositionElements) Should probably have absolute in the name. > Source/WebCore/dom/Element.cpp:1013 > +LayoutRect Element::eventBoundsOfElementAndDescendants(bool& includesFixedPositionElements) Should probably have absolute in the name. This broke Windows build: WebCore.lib(InspectorAllInOne.obj) : error LNK2019: unresolved external symbol "public: class WebCore::FloatPoint __thiscall WebCore::RenderObject::localToAbsolute(class WebCore::FloatPoint const &,unsigned int)const " (?localToAbsolute@RenderObject@WebCore@@QBE?AVFloatPoint@2@ABV32@I@Z) referenced in function "class WebCore::FloatPoint __cdecl WebCore::localPointToRoot(class WebCore::RenderObject *,class WebCore::FrameView const *,class WebCore::FrameView const *,class WebCore::FloatPoint const &)" (?localPointToRoot@WebCore@@YA?AVFloatPoint@1@PAVRenderObject@1@PBVFrameView@1@1ABV21@@Z) [C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj] WebCore.lib(InspectorAllInOne.obj) : error LNK2019: unresolved external symbol "public: class WebCore::IntRect __thiscall WebCore::RenderObject::absoluteBoundingBoxRect(bool)const " (?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z) referenced in function "private: class WTF::Ref<class Inspector::Protocol::LayerTree::Layer> __thiscall WebCore::InspectorLayerTreeAgent::buildObjectForLayer(class WTF::String &,class WebCore::RenderLayer *)" (?buildObjectForLayer@InspectorLayerTreeAgent@WebCore@@AAE?AV?$Ref@VLayer@LayerTree@Protocol@Inspector@@@WTF@@AAVString@4@PAVRenderLayer@2@@Z) [C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj] I don't see anything wrong with the code, will try a clean build. *** Bug 124139 has been marked as a duplicate of this bug. *** |