Bug 142796

Summary: Web Inspector: Removal of multiline completion hint broken in Details sidebar
Product: WebKit Reporter: Tobias Reiss <tobi+webkit>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
demo
none
patch
none
patch none

Description Tobias Reiss 2015-03-17 15:05:56 PDT
What steps will reproduce the problem?
1. Open the Inspector and select some element in the Elements tab.
2. In the Details sidebar, add "text-align: left; display:none"
3. Remove "e" and type "e" again.
4. Trigger "blur" and click outside of the Sidebar

What is the expected result?
Text wraps into multiple lines

What happens instead?
The text "none" is appended to the end of the first line
Comment 1 Tobias Reiss 2015-03-17 15:25:09 PDT
Created attachment 248874 [details]
demo
Comment 2 Tobias Reiss 2015-03-17 15:51:21 PDT
Created attachment 248879 [details]
patch
Comment 3 Joseph Pecoraro 2015-03-17 16:09:49 PDT
Comment on attachment 248879 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248879&action=review

Nice find!

> Source/WebInspectorUI/ChangeLog:8
> +        Priorize CodeMirrorCompletionController over CSSStyleDeclarationTextEditor. Both classes

Typo: "priorize" => "prioritize"?
Comment 4 Tobias Reiss 2015-03-17 16:14:54 PDT
Created attachment 248882 [details]
patch
Comment 5 WebKit Commit Bot 2015-03-17 17:03:43 PDT
Comment on attachment 248882 [details]
patch

Clearing flags on attachment: 248882

Committed r181672: <http://trac.webkit.org/changeset/181672>
Comment 6 WebKit Commit Bot 2015-03-17 17:03:48 PDT
All reviewed patches have been landed.  Closing bug.