Bug 142796 - Web Inspector: Removal of multiline completion hint broken in Details sidebar
Summary: Web Inspector: Removal of multiline completion hint broken in Details sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-17 15:05 PDT by Tobias Reiss
Modified: 2015-03-17 17:03 PDT (History)
8 users (show)

See Also:

Attachments
demo (319.21 KB, image/gif)
2015-03-17 15:25 PDT, Tobias Reiss 		no flags Details
patch (2.60 KB, patch)
2015-03-17 15:51 PDT, Tobias Reiss 		no flags Details | Formatted Diff | Diff
patch (2.60 KB, patch)
2015-03-17 16:14 PDT, Tobias Reiss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Reiss 2015-03-17 15:05:56 PDT 
What steps will reproduce the problem?
1. Open the Inspector and select some element in the Elements tab.
2. In the Details sidebar, add "text-align: left; display:none"
3. Remove "e" and type "e" again.
4. Trigger "blur" and click outside of the Sidebar

What is the expected result?
Text wraps into multiple lines

What happens instead?
The text "none" is appended to the end of the first line
Comment 1 Tobias Reiss 2015-03-17 15:25:09 PDT 
Created attachment 248874 [details]
demo
Comment 2 Tobias Reiss 2015-03-17 15:51:21 PDT 
Created attachment 248879 [details]
patch
Comment 3 Joseph Pecoraro 2015-03-17 16:09:49 PDT 
Comment on attachment 248879 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248879&action=review

Nice find!

> Source/WebInspectorUI/ChangeLog:8
> +        Priorize CodeMirrorCompletionController over CSSStyleDeclarationTextEditor. Both classes

Typo: "priorize" => "prioritize"?
Comment 4 Tobias Reiss 2015-03-17 16:14:54 PDT 
Created attachment 248882 [details]
patch
Comment 5 WebKit Commit Bot 2015-03-17 17:03:43 PDT 
Comment on attachment 248882 [details]
patch

Clearing flags on attachment: 248882

Committed r181672: <http://trac.webkit.org/changeset/181672>
Comment 6 WebKit Commit Bot 2015-03-17 17:03:48 PDT 
All reviewed patches have been landed.  Closing bug.