Bug 142794

Summary: check-webkit-style should allow "bool a : 1"
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Description Dean Jackson 2015-03-17 15:01:47 PDT 
check-webkit-style should allow "bool a : 1"
Comment 1 Dean Jackson 2015-03-17 15:03:20 PDT 
We should allow this type of bitfield in the style checker:

bool m_var : 1;

At the moment we warn, suggesting we should use unsigned. But we're actually using bool in a lot of places because Visual Studio 8 was the last compiler that wasn't happy, and we're long past that.
Comment 2 Dean Jackson 2015-03-17 15:07:38 PDT 
Created attachment 248872 [details]
Patch
Comment 3 Brent Fulgham 2015-03-17 15:14:47 PDT 
Comment on attachment 248872 [details]
Patch

r=me
Comment 4 Dean Jackson 2015-03-17 15:58:39 PDT 
Committed r181669: <http://trac.webkit.org/changeset/181669>