Bug 142780

Summary: [GTK] Wrong transfer annotations used in GObject DOM bindings
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mcrha, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2015-03-17 03:30:01 PDT
We are using transfer none for all methods returning a GObject DOM Object. That's not true. Only objects derived by Node are automatically released by the DOM object cache and can be transfer none. All other objects are added to the cache only to avoid creating the same wrapper twice for the same core object, but caller should release the returned reference. See also bug #118788
Attachments
Patch (5.49 KB, patch)
2015-03-17 03:33 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-03-17 03:33:11 PDT
Created attachment 248841 [details] Patch
Carlos Garcia Campos
Comment 2 2015-03-17 05:22:47 PDT
Committed r181643: <http://trac.webkit.org/changeset/181643>
Note You need to log in before you can comment on or make changes to this bug.