Bug 142777

Summary:

Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[SCREENSHOT] before filter is applied.	none
[SCREENSHOT] After filter is applied.	none
[PATCH] fix.	none

Description Jonathan Wells 2015-03-17 02:09:44 PDT

When typing text into the input field of the filter bar beneath the debugger sidebar (breakpoints), the files that remain do not show their breakpoints.

To reproduce:

1. Add a breakpoint to a script file in a loaded page in the Debugger view.
2. Type in the first letter of that file into the filter bar

The breakpoint isn't visible as it should be.

Screenshots attached.

Comment 1 Radar WebKit Bug Importer 2015-03-17 02:10:25 PDT

<rdar://problem/20186576>

Comment 2 Jonathan Wells 2015-03-17 02:11:03 PDT

Created attachment 248831 [details]
[SCREENSHOT] before filter is applied.

Comment 3 Jonathan Wells 2015-03-17 02:11:47 PDT

Created attachment 248832 [details]
[SCREENSHOT] After filter is applied.

Comment 4 Timothy Hatcher 2015-03-17 09:43:11 PDT

This should be easy to fix by adding filterableData to the BreakpointTreeElement that contains the URL of the resource. Like ResourceTreeElement has.

Comment 5 Jonathan Wells 2015-03-18 22:21:05 PDT

Created attachment 249016 [details]
[PATCH] fix.

Comment 6 Brian Burg 2015-03-19 13:37:45 PDT

Comment on attachment 249016 [details]
[PATCH] fix.

r=me

Comment 7 WebKit Commit Bot 2015-03-19 14:45:36 PDT

Comment on attachment 249016 [details]
[PATCH] fix.

Clearing flags on attachment: 249016

Committed r181759: <http://trac.webkit.org/changeset/181759>

Comment 8 WebKit Commit Bot 2015-03-19 14:45:40 PDT

All reviewed patches have been landed.  Closing bug.