Bug 142777

Summary:

Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[SCREENSHOT] before filter is applied.	none
[SCREENSHOT] After filter is applied.	none
[PATCH] fix.	none

Jonathan Wells

Reported 2015-03-17 02:09:44 PDT

When typing text into the input field of the filter bar beneath the debugger sidebar (breakpoints), the files that remain do not show their breakpoints. To reproduce: 1. Add a breakpoint to a script file in a loaded page in the Debugger view. 2. Type in the first letter of that file into the filter bar The breakpoint isn't visible as it should be. Screenshots attached.

Attachments
[SCREENSHOT] before filter is applied. (38.49 KB, image/png) 2015-03-17 02:11 PDT, Jonathan Wells	no flags	Details
[SCREENSHOT] After filter is applied. (22.39 KB, image/png) 2015-03-17 02:11 PDT, Jonathan Wells	no flags	Details
[PATCH] fix. (1.66 KB, patch) 2015-03-18 22:21 PDT, Jonathan Wells	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-03-17 02:10:25 PDT

<rdar://problem/20186576>

Jonathan Wells

Comment 2 2015-03-17 02:11:03 PDT

Created attachment 248831 [details] [SCREENSHOT] before filter is applied.

Jonathan Wells

Comment 3 2015-03-17 02:11:47 PDT

Created attachment 248832 [details] [SCREENSHOT] After filter is applied.

Timothy Hatcher

Comment 4 2015-03-17 09:43:11 PDT

This should be easy to fix by adding filterableData to the BreakpointTreeElement that contains the URL of the resource. Like ResourceTreeElement has.

Jonathan Wells

Comment 5 2015-03-18 22:21:05 PDT

Created attachment 249016 [details] [PATCH] fix.

Brian Burg

Comment 6 2015-03-19 13:37:45 PDT

Comment on attachment 249016 [details] [PATCH] fix. r=me

WebKit Commit Bot

Comment 7 2015-03-19 14:45:36 PDT

Comment on attachment 249016 [details] [PATCH] fix. Clearing flags on attachment: 249016 Committed r181759: <http://trac.webkit.org/changeset/181759>

WebKit Commit Bot

Comment 8 2015-03-19 14:45:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.