Bug 142749

Summary: Windows X86-64 should use the fixed executable allocator
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2 Keywords: InRadar
Version: 312.x   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
msaboff: review-
Updated patch none

Michael Saboff
Reported 2015-03-16 14:45:32 PDT
Windows currently uses the demand based executable allocator. Using the demand based allocator can result in executable memory in various parts of the address space. Currently, the JSC JITs expect that all JIT'ed addresses is within a 32 bit offset of each other. The demand executable allocator cannot provide such a guarantee, therefore Windows X86-64 should use the fixed allocator like the rest of the X86-64 platforms. <rdar://problem/19804738>
Attachments
Patch (1.30 KB, patch)
2015-03-16 14:47 PDT, Michael Saboff 		msaboff: review-
DetailsFormatted DiffDiff
Updated patch (6.34 KB, patch)
2015-03-16 19:09 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-03-16 14:47:33 PDT
Created attachment 248750 [details] Patch
Michael Saboff
Comment 2 2015-03-16 14:55:10 PDT
Looks like the Windows implementation of the fixed allocator is not complete. More work to do.
Michael Saboff
Comment 3 2015-03-16 19:09:19 PDT
Created attachment 248780 [details] Updated patch
WebKit Commit Bot
Comment 4 2015-03-17 02:34:05 PDT
Comment on attachment 248780 [details] Updated patch Clearing flags on attachment: 248780 Committed r181628: <http://trac.webkit.org/changeset/181628>
WebKit Commit Bot
Comment 5 2015-03-17 02:34:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.