Bug 142749 - Windows X86-64 should use the fixed executable allocator
Summary: Windows X86-64 should use the fixed executable allocator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 312.x
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-16 14:45 PDT by Michael Saboff
Modified: 2015-03-17 02:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2015-03-16 14:47 PDT, Michael Saboff 		msaboff: review-
Details | Formatted Diff | Diff
Updated patch (6.34 KB, patch)
2015-03-16 19:09 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-03-16 14:45:32 PDT 
Windows currently uses the demand based executable allocator.  Using the demand based allocator can result in executable memory in various parts of the address space.  Currently, the JSC JITs expect that all JIT'ed addresses is within a 32 bit offset of each other.  The demand executable allocator cannot provide such a guarantee, therefore Windows X86-64 should use the fixed allocator like the rest of the X86-64 platforms.

<rdar://problem/19804738>
Comment 1 Michael Saboff 2015-03-16 14:47:33 PDT 
Created attachment 248750 [details]
Patch
Comment 2 Michael Saboff 2015-03-16 14:55:10 PDT 
Looks like the Windows implementation of the fixed allocator is not complete.  More work to do.
Comment 3 Michael Saboff 2015-03-16 19:09:19 PDT 
Created attachment 248780 [details]
Updated patch
Comment 4 WebKit Commit Bot 2015-03-17 02:34:05 PDT 
Comment on attachment 248780 [details]
Updated patch

Clearing flags on attachment: 248780

Committed r181628: <http://trac.webkit.org/changeset/181628>
Comment 5 WebKit Commit Bot 2015-03-17 02:34:10 PDT 
All reviewed patches have been landed.  Closing bug.