Bug 142744

Summary: Expose WK2 preference for Animation Triggers runtime flag
Product: WebKit Reporter: Dean Jackson <dino>
Component: AnimationsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dino, ossy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Dean Jackson
Reported 2015-03-16 13:48:45 PDT
We need a WK2 preference for the runtime flag.
Attachments
Patch (7.04 KB, patch)
2015-03-16 14:19 PDT, Dean Jackson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-16 13:49:50 PDT
<rdar://problem/20178288>
Dean Jackson
Comment 2 2015-03-16 14:19:15 PDT
Created attachment 248748 [details] Patch
Dean Jackson
Comment 3 2015-03-16 14:26:18 PDT
Committed r181578: <http://trac.webkit.org/changeset/181578>
Csaba Osztrogonác
Comment 4 2015-03-16 15:45:17 PDT
Comment on attachment 248748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248748&action=review > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:620 > +void InjectedBundle::setCSSAnimationTriggersEnabled(bool enabled) > +{ > +#if ENABLE(CSS_REGIONS) > + RuntimeEnabledFeatures::sharedFeatures().setAnimationTriggersEnabled(enabled); > +#else > + UNUSED_PARAM(enabled); > +#endif > +} CSS_REGIONS ??? This is so ugly typo. That's why it broke the EFL and GTK builds. I know you are allowed to do it ... but I can't understand why was it needed ...
Csaba Osztrogonác
Comment 5 2015-03-16 15:46:58 PDT
Typo fix landed in http://trac.webkit.org/changeset/181582
Csaba Osztrogonác
Comment 6 2015-03-16 15:48:54 PDT
One more fix landed in http://trac.webkit.org/changeset/181584
Dean Jackson
Comment 7 2015-03-16 17:11:52 PDT
Thanks Ossy, and apologies.
Note You need to log in before you can comment on or make changes to this bug.