Bug 142735
| Summary: | Style Check: runtime/enum_bitfields should allow "bool" values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dean Jackson
A declaration like this:
bool m_foo : 1;
Produces a warning:
ERROR: Source/WebCore/platform/animation/Animation.h:202: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
The source code talks about VS8, which is very very old. Also, it seems many people were ignoring this rule anyway.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
This warning is no longer relevant. Visual Studio 2013 (our only supported Windows compiler) and newer all support this syntax.
This warning should be removed!