Bug 142718

Summary:

REGRESSION(r181517): This patch broke GTK+ build (Requested by NVI on #webkit).

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

New Bugs

Assignee:

WebKit Commit Bot <commit-queue>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

142712

Attachments:

Description	Flags
ROLLOUT of r181517	none

Description WebKit Commit Bot 2015-03-15 18:51:05 PDT

http://trac.webkit.org/changeset/181517 broke the build:
This patch broke GTK+ build (Requested by NVI on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

Comment 1 WebKit Commit Bot 2015-03-15 18:51:32 PDT

Created attachment 248697 [details]
ROLLOUT of r181517

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 WebKit Commit Bot 2015-03-15 18:54:36 PDT

Comment on attachment 248697 [details]
ROLLOUT of r181517

Rejecting attachment 248697 [details] from commit-queue.

nvasilyev@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

Comment 3 Joseph Pecoraro 2015-03-16 11:12:17 PDT

Comment on attachment 248697 [details]
ROLLOUT of r181517

GTK bot should just need a clean build. It is picking up a file in the derived sources that should no longer exist.

Comment 4 WebKit Commit Bot 2015-03-16 11:12:34 PDT

Comment on attachment 248697 [details]
ROLLOUT of r181517

Clearing flags on attachment: 248697

Committed r181567: <http://trac.webkit.org/changeset/181567>

Comment 5 WebKit Commit Bot 2015-03-16 11:12:37 PDT

All reviewed patches have been landed.  Closing bug.