Bug 142718 - REGRESSION(r181517): This patch broke GTK+ build (Requested by NVI on #webkit).
Summary: REGRESSION(r181517): This patch broke GTK+ build (Requested by NVI on #webkit).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 142712
  Show dependency treegraph
 
Reported: 2015-03-15 18:51 PDT by WebKit Commit Bot
Modified: 2015-03-16 11:12 PDT (History)
1 user (show)

See Also:


Attachments
ROLLOUT of r181517 (87.72 KB, patch)
2015-03-15 18:51 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2015-03-15 18:51:05 PDT
http://trac.webkit.org/changeset/181517 broke the build:
This patch broke GTK+ build (Requested by NVI on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2015-03-15 18:51:32 PDT
Created attachment 248697 [details]
ROLLOUT of r181517

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2015-03-15 18:54:36 PDT
Comment on attachment 248697 [details]
ROLLOUT of r181517

Rejecting attachment 248697 [details] from commit-queue.

nvasilyev@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Joseph Pecoraro 2015-03-16 11:12:17 PDT
Comment on attachment 248697 [details]
ROLLOUT of r181517

GTK bot should just need a clean build. It is picking up a file in the derived sources that should no longer exist.
Comment 4 WebKit Commit Bot 2015-03-16 11:12:34 PDT
Comment on attachment 248697 [details]
ROLLOUT of r181517

Clearing flags on attachment: 248697

Committed r181567: <http://trac.webkit.org/changeset/181567>
Comment 5 WebKit Commit Bot 2015-03-16 11:12:37 PDT
All reviewed patches have been landed.  Closing bug.