| Summary: | ES6 class syntax should allow computed name method | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||||||
| Component: | JavaScriptCore | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, joepeck, mmirman, msaboff, saam, ysuzuki | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 140491 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Ryosuke Niwa
2015-03-13 23:59:34 PDT
Created attachment 248641 [details]
Fixes the bug
Created attachment 248819 [details]
Updated for ToT
Created attachment 248828 [details]
Updated for ToT again
Comment on attachment 248828 [details]
Updated for ToT again
This no longer applies on ToT.
Created attachment 249848 [details]
Fixes the bug
Comment on attachment 249848 [details]
Fixes the bug
Wrong bug.
Created attachment 258984 [details]
Adds the support
Created attachment 259027 [details]
Updated for ToT
Created attachment 259032 [details]
Fixed 32-bit build
Comment on attachment 259032 [details]
Fixed 32-bit build
r=me
I think it'd be good to have tests for computed method names that have side effects and we should assert that we do things in the correct order:
"[(x = 20, "foo")] {..}, [assert(x === 20), "bar"] {...}".
Ryosuke says he will open up another bug for this.
Comment on attachment 259032 [details] Fixed 32-bit build Clearing flags on attachment: 259032 Committed r188498: <http://trac.webkit.org/changeset/188498> All reviewed patches have been landed. Closing bug. |