Bug 142686

Summary: Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 141174    
Attachments:
Description Flags
the patch oliver: review+

Description Filip Pizlo 2015-03-13 18:37:42 PDT 
When you run the elidable-new-object-roflcopter test, you'll see that there are many repeated PutStructureHints and PutByOffsetHints.  These are because we handle already-sunken allocations from previous fixpoint iterations inside the code for handling those allocations we are sinking on *this* fixpoint iteration.  This is a mostly benign bug; its main effect is that if the phase does many fixpoint iterations then you'll get a lot of duplicated code.
Comment 1 Filip Pizlo 2015-03-13 18:39:21 PDT 
Created attachment 248631 [details]
the patch
Comment 2 Filip Pizlo 2015-03-13 19:51:36 PDT 
Landed in http://trac.webkit.org/changeset/181495