Bug 142680

Summary:

progress towards cake on mac

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebKit Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, gyuyoung.kim

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Alex Christensen 2015-03-13 15:52:49 PDT

progress

Comment 1 Alex Christensen 2015-03-13 16:25:47 PDT

Created attachment 248618 [details]
Patch

Comment 2 Alex Christensen 2015-03-13 16:37:18 PDT

Created attachment 248619 [details]
Patch

Comment 3 Gyuyoung Kim 2015-03-13 17:38:40 PDT

Comment on attachment 248619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248619&action=review

LGTM as in-progress patch to use CMake for Mac and Win ports.

> CMakeLists.txt:30
> +    set(WebKit_LIBRARY_TYPE SHARED)

LIBRARY_TYPE is defined in 135 ~ 136 lines. It would be define it there.

135: set(WebKit2_LIBRARY_TYPE SHARED)
136: set(WebCoreTestSupport_LIBRARY_TYPE STATIC)

> Source/WebCore/PlatformMac.cmake:26
> +    "${WEBCORE_DIR}/platform/spi/cf"

nit: Looks like wrong alphabet order.

Comment 4 Alex Christensen 2015-03-13 18:09:18 PDT

Created attachment 248628 [details]
Patch

Comment 5 Geoffrey Garen 2015-03-13 18:15:46 PDT

I want cake!

Comment 6 Alex Christensen 2015-03-13 19:59:57 PDT

http://trac.webkit.org/changeset/181496

Geoff, go get some cake!  CMake works with jsc on Mac now.