Bug 142637

Summary: ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Severity: Normal CC: andersca, commit-queue, dino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=133227
Description Flags
proposed fix none

Description Alexey Proskuryakov 2015-03-12 13:11:59 PDT
I get an assertion when running this test locally, always reproducible by repeating it multiple times:

run-webkit-tests plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html --repeat 100

The reason is that the QuickTime plug-in is 32-bit, so it fails to initialize, PluginView::didFailToInitializePlugin() sets m_plugin to 0, but then we start m_pluginSnapshotTimer regardless.

This makes me confused about how this test (or other snapshotting tests) can ever pass on any debug local builds. They all expect a snapshot that shouldn't be possible to make. 

See also rdar://problem/18994117, rdar://problem/16097212.
Comment 1 Alexey Proskuryakov 2015-03-16 16:11:23 PDT
Created attachment 248764 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-03-16 16:59:04 PDT
Comment on attachment 248764 [details]
proposed fix

Clearing flags on attachment: 248764

Committed r181599: <http://trac.webkit.org/changeset/181599>
Comment 3 WebKit Commit Bot 2015-03-16 16:59:08 PDT
All reviewed patches have been landed.  Closing bug.