Bug 142633

Summary: LLInt's inline cache should use StructureID instead of Structure*.
Product: WebKit Reporter: Jiho Choi <jray319>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: beidson, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.10   
Attachments:
Description Flags
Patch beidson: review-

Jiho Choi
Reported 2015-03-12 12:11:08 PDT
Initially discussed here: https://lists.webkit.org/pipermail/webkit-dev/2015-March/027294.html LLInt's inline cache seems to be left out when refactoring JSCell to have 32-bit StructureID. LLInt's inline cache is currently using Structure* even in 64-bit platforms where StructureID is uint32_t so that it requires an extra load to retrieve Structure*. Note that there is no such indirection in 32-bit platform where StructureID is typedef'ed as Structure*. This patch is to change LLInt's inline cache to use StructureID, and it will mostly affect 64-bit platform and remove unnecessary loads in LLInt's inline cache.
Attachments
Patch (15.47 KB, patch)
2015-03-13 09:26 PDT, Jiho Choi 		beidson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiho Choi
Comment 1 2015-03-12 12:17:23 PDT
Working on it.
Jiho Choi
Comment 2 2015-03-13 09:26:28 PDT
Created attachment 248586 [details] Patch
Brady Eidson
Comment 3 2017-04-24 19:05:44 PDT
Comment on attachment 248586 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note You need to log in before you can comment on or make changes to this bug.