Bug 142633

Summary:

LLInt's inline cache should use StructureID instead of Structure*.

Product:

WebKit

Reporter:

Jiho Choi <jray319>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

beidson, fpizlo

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.10

Attachments:

Description	Flags
Patch	beidson: review-

Description Jiho Choi 2015-03-12 12:11:08 PDT

Initially discussed here:
https://lists.webkit.org/pipermail/webkit-dev/2015-March/027294.html

LLInt's inline cache seems to be left out when refactoring JSCell to have 32-bit StructureID. LLInt's inline cache is currently using Structure* even in 64-bit platforms where StructureID is uint32_t so that it requires an extra load to retrieve Structure*. Note that there is no such indirection in 32-bit platform where StructureID is typedef'ed as Structure*.
This patch is to change LLInt's inline cache to use StructureID, and it will mostly affect 64-bit platform and remove unnecessary loads in LLInt's inline cache.

Comment 1 Jiho Choi 2015-03-12 12:17:23 PDT

Working on it.

Comment 2 Jiho Choi 2015-03-13 09:26:28 PDT

Created attachment 248586 [details]
Patch

Comment 3 Brady Eidson 2017-04-24 19:05:44 PDT

Comment on attachment 248586 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.