Bug 142613

Summary:

[cmake] Fix the incremental build issue revealed by r181419

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, clopez, commit-queue, gyuyoung.kim, mark.lam, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

142600

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-03-12 02:07:07 PDT

After https://trac.webkit.org/changeset/181419 the build was broken on the
EFL performance bot and the GTK ARM bot. But it must be an incremental build
issue, because clean build solved the problem.

The goal of this bug is to add the missing dependency to 
the cmake build system to avoid same error in the future.

Comment 1 Csaba Osztrogonác 2015-03-12 02:12:27 PDT

error log:

In file included from ../../Source/JavaScriptCore/parser/Lexer.cpp:41:0:
DerivedSources/JavaScriptCore/KeywordLookup.h: In member function 'JSC::JSTokenType JSC::Lexer<T>::parseKeyword(JSC::JSTokenData*) [with bool shouldCreateIdentifier = shouldCreateIdentifier; T = short unsigned int]':
DerivedSources/JavaScriptCore/KeywordLookup.h:434:24: error: 'STATICTOKEN' was not declared in this scope
DerivedSources/JavaScriptCore/KeywordLookup.h: In member function 'JSC::JSTokenType JSC::Lexer<T>::parseKeyword(JSC::JSTokenData*) [with bool shouldCreateIdentifier = shouldCreateIdentifier; T = unsigned char]':
DerivedSources/JavaScriptCore/KeywordLookup.h:798:24: error: 'STATICTOKEN' was not declared in this scope

Comment 2 Csaba Osztrogonác 2015-03-12 02:17:28 PDT

DerivedSources/JavaScriptCore/KeywordLookup.h wasn't regenerated,
but it should have been. Keywords.table is missing from the dependency
list. Fix is coming.

Comment 3 Csaba Osztrogonác 2015-03-12 02:19:08 PDT

Created attachment 248503 [details]
Patch

Comment 4 WebKit Commit Bot 2015-03-12 03:17:05 PDT

The commit-queue encountered the following flaky tests while processing attachment 248503 [details]:

The commit-queue is continuing to process your patch.

Comment 5 WebKit Commit Bot 2015-03-12 03:17:48 PDT

The commit-queue encountered the following flaky tests while processing attachment 248503 [details]:

compositing/geometry/clipped-video-controller.html bug 142615 (authors: adamk@chromium.org, mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
The commit-queue is continuing to process your patch.

Comment 6 WebKit Commit Bot 2015-03-12 03:28:15 PDT

Comment on attachment 248503 [details]
Patch

Clearing flags on attachment: 248503

Committed r181435: <http://trac.webkit.org/changeset/181435>

Comment 7 WebKit Commit Bot 2015-03-12 03:28:20 PDT

All reviewed patches have been landed.  Closing bug.