Bug 142586

Summary:

[Mac] Update fullscreen placeholder UI to use Vibrancy.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jer Noble 2015-03-11 11:21:51 PDT

[Mac] Update fullscreen placeholder view to support Vibrancy.

Comment 1 Jer Noble 2015-03-11 11:43:58 PDT

Created attachment 248436 [details]
Patch

Comment 2 Eric Carlson 2015-03-11 11:47:47 PDT

Comment on attachment 248436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248436&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> +    _effectView.get().wantsLayer = YES;
> +    _effectView.get().autoresizesSubviews = YES;
> +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> +    _effectView.get().hidden = YES;
> +    _effectView.get().material = NSVisualEffectMaterialLight;
> +    _effectView.get().state = NSVisualEffectStateActive;

Nit: that is a lot of ".get()."s

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> +    _exitWarning.get().bordered = NO;
> +    _exitWarning.get().drawsBackground = NO;
> +    _exitWarning.get().editable = NO;
> +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> +    _exitWarning.get().selectable = NO;
> +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];

Ditto.

Comment 3 Jer Noble 2015-03-11 11:48:35 PDT

(In reply to comment #2)
> Comment on attachment 248436 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248436&action=review
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> > +    _effectView.get().wantsLayer = YES;
> > +    _effectView.get().autoresizesSubviews = YES;
> > +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> > +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> > +    _effectView.get().hidden = YES;
> > +    _effectView.get().material = NSVisualEffectMaterialLight;
> > +    _effectView.get().state = NSVisualEffectStateActive;
> 
> Nit: that is a lot of ".get()."s
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> > +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> > +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> > +    _exitWarning.get().bordered = NO;
> > +    _exitWarning.get().drawsBackground = NO;
> > +    _exitWarning.get().editable = NO;
> > +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> > +    _exitWarning.get().selectable = NO;
> > +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> > +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];
> 
> Ditto.

The alternative is (e.g.) [_exitWarning setBordered:NO] which is (underneath the hood) an equal number of get()s.

Comment 4 Jer Noble 2015-03-11 12:44:18 PDT

<rdar://problem/20062753>

Comment 5 WebKit Commit Bot 2015-03-11 13:28:13 PDT

Comment on attachment 248436 [details]
Patch

Clearing flags on attachment: 248436

Committed r181403: <http://trac.webkit.org/changeset/181403>

Comment 6 WebKit Commit Bot 2015-03-11 13:28:17 PDT

All reviewed patches have been landed.  Closing bug.