| Summary: | Fix build warning in WebKit2/NetworkProcess module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||
| Component: | WebKit2 | Assignee: | Shivakumar J M <shiva.jm> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | commit-queue, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 248405 [details]
Patch
Fix build warning by removing argument name from function.
Attachment 248405 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 248405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248405&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369 > +void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& , const Vector<String>& cookieHostNames, uint64_t callbackID) Should not have left in a space before the comma. After http://trac.webkit.org/changeset/181318 we don't need to fix this kind of warnings in WebKit2, they are silenced similar to Mac build. (In reply to comment #4) > After http://trac.webkit.org/changeset/181318 we don't need to fix this > kind of warnings in WebKit2, they are silenced similar to Mac build. Ok, will mark these issue as wontfix |
Got build warnign in latest build for efl port. ../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268:13: warning: unused parameter ‘sessionID’ [-Wunused-parameter] static void fetchDiskCacheEntries(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler) ^ ../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:6: warning: unused parameter ‘origins’ [-Wunused-parameter] void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID)