Bug 142565

Summary: Add some DateMath test to TestWebKitAPI
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Brent Fulgham
Reported 2015-03-10 21:39:05 PDT
The recent Daylight Savings Time bug in Windows showed that we have no DateMath test coverage. Let's fix that!
Attachments
Patch (10.61 KB, patch)
2015-03-10 21:43 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (14.85 KB, patch)
2015-03-11 09:33 PDT, Brent Fulgham 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-03-10 21:43:18 PDT
Created attachment 248396 [details] Patch
Brent Fulgham
Comment 2 2015-03-11 00:02:56 PDT
I'll upload a patch with mac, Gtk, and EFL settings tomorrow.
Brent Fulgham
Comment 3 2015-03-11 09:33:23 PDT
Created attachment 248426 [details] Patch
Brent Fulgham
Comment 4 2015-03-11 10:01:11 PDT
Comment on attachment 248426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review > Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:189 > + */ I should get rid of this!
Alexey Proskuryakov
Comment 5 2015-03-11 10:30:02 PDT
Comment on attachment 248426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review rs=me > Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:122 > + EXPECT_EQ(1, WTF::dayInMonthFromDayInYear(0, false)); Public WTF symbols are supposed to be used without "WTF", they should always have a using declaration right in the WTF header.
Brent Fulgham
Comment 6 2015-03-11 10:45:42 PDT
Comment on attachment 248426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review >> Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:122 >> + EXPECT_EQ(1, WTF::dayInMonthFromDayInYear(0, false)); > > Public WTF symbols are supposed to be used without "WTF", they should always have a using declaration right in the WTF header. I'll fix that before landing.
Brent Fulgham
Comment 7 2015-03-11 10:49:31 PDT
Committed r181393: <http://trac.webkit.org/changeset/181393>
Note You need to log in before you can comment on or make changes to this bug.