Bug 142564

Summary:

Allow adding a button in input elements for auto fill related functionality

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, jake.nielsen.webkit, jberlin, mattbaker, rmondello, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	none
Patch	none
Patch	andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Archive of layout-test-results from ews102 for mac-mavericks	none

Sam Weinig

Reported 2015-03-10 21:16:06 PDT

Allow adding a button in input elements for auto fill related functionality

Attachments
Patch (76.97 KB, patch) 2015-03-10 21:41 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (534.07 KB, application/zip) 2015-03-10 22:33 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (563.98 KB, application/zip) 2015-03-10 22:40 PDT, Build Bot	no flags	Details
Patch (77.56 KB, patch) 2015-03-11 08:28 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (77.03 KB, patch) 2015-03-11 11:05 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (77.81 KB, patch) 2015-03-11 11:14 PDT, Sam Weinig	andersca: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (716.64 KB, application/zip) 2015-03-11 12:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mavericks (567.67 KB, application/zip) 2015-03-11 12:19 PDT, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2015-03-10 21:41:07 PDT

Created attachment 248395 [details] Patch

Sam Weinig

Comment 2 2015-03-10 21:41:48 PDT

<rdar://problem/19782066>

WebKit Commit Bot

Comment 3 2015-03-10 21:42:36 PDT

Attachment 248395 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLInputElement.h:435: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/WebCore/html/HTMLInputElement.h:436: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 4 2015-03-10 22:33:15 PDT

Comment on attachment 248395 [details] Patch Attachment 248395 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6315975758577664 New failing tests: fast/forms/input-auto-fill-button.html

Build Bot

Comment 5 2015-03-10 22:33:17 PDT

Created attachment 248400 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 6 2015-03-10 22:40:28 PDT

Comment on attachment 248395 [details] Patch Attachment 248395 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6296498081890304 New failing tests: fast/forms/input-auto-fill-button.html

Build Bot

Comment 7 2015-03-10 22:40:30 PDT

Created attachment 248401 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Sam Weinig

Comment 8 2015-03-11 08:28:40 PDT

Created attachment 248419 [details] Patch

WebKit Commit Bot

Comment 9 2015-03-11 08:31:29 PDT

Attachment 248419 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLInputElement.h:435: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/WebCore/html/HTMLInputElement.h:436: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 10 2015-03-11 11:05:19 PDT

Created attachment 248434 [details] Patch

WebKit Commit Bot

Comment 11 2015-03-11 11:07:58 PDT

Attachment 248434 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLInputElement.h:435: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/WebCore/html/HTMLInputElement.h:436: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 12 2015-03-11 11:14:01 PDT

Created attachment 248435 [details] Patch

WebKit Commit Bot

Comment 13 2015-03-11 11:17:39 PDT

Attachment 248435 [details] did not pass style-queue: ERROR: Source/WebCore/html/HTMLInputElement.h:435: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/WebCore/html/HTMLInputElement.h:436: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 14 2015-03-11 12:14:24 PDT

Comment on attachment 248435 [details] Patch Attachment 248435 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5955516333293568 New failing tests: fast/forms/input-auto-fill-button.html

Build Bot

Comment 15 2015-03-11 12:14:33 PDT

Created attachment 248438 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 16 2015-03-11 12:19:31 PDT

Comment on attachment 248435 [details] Patch Attachment 248435 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6679239797506048 New failing tests: fast/forms/input-auto-fill-button.html

Build Bot

Comment 17 2015-03-11 12:19:33 PDT

Created attachment 248439 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Anders Carlsson

Comment 18 2015-03-11 14:41:11 PDT

Comment on attachment 248435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248435&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:81 > +/* Deprecated - use WKBundleNodeHandleGetHTMLInputElementAutoFilled(WKBundleNodeHandleRef) */ > +WK_EXPORT bool WKBundleNodeHandleGetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle); > +/* Deprecated - use WKBundleNodeHandleSetHTMLInputElementAutoFilled(WKBundleNodeHandleRef, bool) */ > +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle, bool filled); Do we really need to have these here? Can't we fix the callers and move the definitions to WKDeprecatedFunctions.cpp?

Sam Weinig

Comment 19 2015-03-11 14:50:49 PDT

(In reply to comment #18) > Comment on attachment 248435 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248435&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:81 > > +/* Deprecated - use WKBundleNodeHandleGetHTMLInputElementAutoFilled(WKBundleNodeHandleRef) */ > > +WK_EXPORT bool WKBundleNodeHandleGetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle); > > +/* Deprecated - use WKBundleNodeHandleSetHTMLInputElementAutoFilled(WKBundleNodeHandleRef, bool) */ > > +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle, bool filled); > > Do we really need to have these here? Can't we fix the callers and move the > definitions to WKDeprecatedFunctions.cpp? I will make that change.

Sam Weinig

Comment 20 2015-03-11 15:01:28 PDT

Committed r181408: <http://trac.webkit.org/changeset/181408>

Alexey Proskuryakov

Comment 21 2015-05-22 12:00:38 PDT

This test fails on Windows, can someone please take care of that? Probably just needs custom results. https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r184774%20(51999)/fast/forms/input-auto-fill-button-diff.txt

Note You need to log in before you can comment on or make changes to this bug.