Bug 142558

Summary: Remove unnecessary create() factory functions
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-03-10 19:08:40 PDT
SSIA
Attachments
Patch (10.01 KB, patch)
2015-03-10 19:10 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (9.90 KB, patch)
2015-03-10 22:54 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-03-10 19:10:23 PDT
Created attachment 248386 [details] Patch
Darin Adler
Comment 2 2015-03-10 22:51:12 PDT
Comment on attachment 248386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248386&action=review > Source/WebCore/testing/MicroTaskTest.h:40 > + // WEBCORE_TESTSUPPORT_EXPORT static std::unique_ptr<MicroTaskTest> create(WeakPtr<Document>, int testNumber); Why this commented-out line of code?
Gyuyoung Kim
Comment 3 2015-03-10 22:54:24 PDT
Created attachment 248403 [details] Patch
Gyuyoung Kim
Comment 4 2015-03-10 22:55:06 PDT
Comment on attachment 248386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248386&action=review >> Source/WebCore/testing/MicroTaskTest.h:40 >> + // WEBCORE_TESTSUPPORT_EXPORT static std::unique_ptr<MicroTaskTest> create(WeakPtr<Document>, int testNumber); > > Why this commented-out line of code? Oops, mistake. Thank you for your nice catch !
WebKit Commit Bot
Comment 5 2015-03-11 00:10:38 PDT
Comment on attachment 248403 [details] Patch Clearing flags on attachment: 248403 Committed r181368: <http://trac.webkit.org/changeset/181368>
WebKit Commit Bot
Comment 6 2015-03-11 00:10:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.