Bug 142558 - Remove unnecessary create() factory functions
Summary: Remove unnecessary create() factory functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 19:08 PDT by Gyuyoung Kim
Modified: 2015-03-11 00:10 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.01 KB, patch)
2015-03-10 19:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (9.90 KB, patch)
2015-03-10 22:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-10 19:08:40 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-03-10 19:10:23 PDT 
Created attachment 248386 [details]
Patch
Comment 2 Darin Adler 2015-03-10 22:51:12 PDT 
Comment on attachment 248386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248386&action=review

> Source/WebCore/testing/MicroTaskTest.h:40
> +    // WEBCORE_TESTSUPPORT_EXPORT static std::unique_ptr<MicroTaskTest> create(WeakPtr<Document>, int testNumber);

Why this commented-out line of code?
Comment 3 Gyuyoung Kim 2015-03-10 22:54:24 PDT 
Created attachment 248403 [details]
Patch
Comment 4 Gyuyoung Kim 2015-03-10 22:55:06 PDT 
Comment on attachment 248386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248386&action=review

>> Source/WebCore/testing/MicroTaskTest.h:40
>> +    // WEBCORE_TESTSUPPORT_EXPORT static std::unique_ptr<MicroTaskTest> create(WeakPtr<Document>, int testNumber);
> 
> Why this commented-out line of code?

Oops, mistake. Thank you for your nice catch !
Comment 5 WebKit Commit Bot 2015-03-11 00:10:38 PDT 
Comment on attachment 248403 [details]
Patch

Clearing flags on attachment: 248403

Committed r181368: <http://trac.webkit.org/changeset/181368>
Comment 6 WebKit Commit Bot 2015-03-11 00:10:42 PDT 
All reviewed patches have been landed.  Closing bug.