| Summary: | Functions should have initialization precedence over arguments. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Mirman <mmirman> | ||||
| Component: | JavaScriptCore | Assignee: | Matthew Mirman <mmirman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, fpizlo, ggaren, mmirman, msaboff | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Matthew Mirman
2015-03-10 16:19:28 PDT
Created attachment 248369 [details]
Patch.
Ran JSC stress tests on debug without any failures.
Comment on attachment 248369 [details]
Patch.
r=me
Comment on attachment 248369 [details] Patch. Clearing flags on attachment: 248369 Committed r181353: <http://trac.webkit.org/changeset/181353> All reviewed patches have been landed. Closing bug. Looks like this broke fast/events/event-attribute.html on Windows: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html And when I say "broke", I mean "made it pass": -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was undefined. +PASS /*img*/ typeof (element["ontouchstart"]) is "function" +PASS /*img*/ typeof (element["ontouchmove"]) is "function" +PASS /*img*/ typeof (element["ontouchend"]) is "function" +PASS /*img*/ typeof (element["ontouchcancel"]) is "function" (In reply to comment #5) > Looks like this broke fast/events/event-attribute.html on Windows: > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html > > And when I say "broke", I mean "made it pass": > > -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was > undefined. > +PASS /*img*/ typeof (element["ontouchstart"]) is "function" > +PASS /*img*/ typeof (element["ontouchmove"]) is "function" > +PASS /*img*/ typeof (element["ontouchend"]) is "function" > +PASS /*img*/ typeof (element["ontouchcancel"]) is "function" http://trac.webkit.org/changeset/181414 |