Bug 142550

Summary: Functions should have initialization precedence over arguments.
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Matthew Mirman <mmirman>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, fpizlo, ggaren, mmirman, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. none

Matthew Mirman
Reported 2015-03-10 16:19:28 PDT
patch forthcoming. rdar://problem/19702564
Attachments
Patch. (2.69 KB, patch)
2015-03-10 16:27 PDT, Matthew Mirman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Mirman
Comment 1 2015-03-10 16:27:23 PDT
Created attachment 248369 [details] Patch. Ran JSC stress tests on debug without any failures.
Geoffrey Garen
Comment 2 2015-03-10 16:47:20 PDT
Comment on attachment 248369 [details] Patch. r=me
WebKit Commit Bot
Comment 3 2015-03-10 17:33:33 PDT
Comment on attachment 248369 [details] Patch. Clearing flags on attachment: 248369 Committed r181353: <http://trac.webkit.org/changeset/181353>
WebKit Commit Bot
Comment 4 2015-03-10 17:33:37 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2015-03-11 15:43:20 PDT
Looks like this broke fast/events/event-attribute.html on Windows: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html And when I say "broke", I mean "made it pass": -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was undefined. -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was undefined. +PASS /*img*/ typeof (element["ontouchstart"]) is "function" +PASS /*img*/ typeof (element["ontouchmove"]) is "function" +PASS /*img*/ typeof (element["ontouchend"]) is "function" +PASS /*img*/ typeof (element["ontouchcancel"]) is "function"
Matthew Mirman
Comment 6 2015-03-11 16:53:48 PDT
(In reply to comment #5) > Looks like this broke fast/events/event-attribute.html on Windows: > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html > > And when I say "broke", I mean "made it pass": > > -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was > undefined. > -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was > undefined. > +PASS /*img*/ typeof (element["ontouchstart"]) is "function" > +PASS /*img*/ typeof (element["ontouchmove"]) is "function" > +PASS /*img*/ typeof (element["ontouchend"]) is "function" > +PASS /*img*/ typeof (element["ontouchcancel"]) is "function" http://trac.webkit.org/changeset/181414
Note You need to log in before you can comment on or make changes to this bug.