Bug 142548

Summary: Add support for more emoji with variation
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Enrica Casucci 2015-03-10 15:37:35 PDT
ICU rules need to be adjusted.
Comment 1 Enrica Casucci 2015-03-10 15:41:13 PDT
Created attachment 248366 [details]
Patch
Comment 2 Tim Horton 2015-03-10 16:06:10 PDT
Comment on attachment 248366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review

> LayoutTests/editing/selection/extend-by-character-007.html:11
> +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>

quotes around the src value, no need for language or type attrs.

> LayoutTests/editing/selection/extend-by-character-007.html:16
> +    for (i = 0; i < 4; i++) {

var i
Comment 3 Enrica Casucci 2015-03-10 16:13:34 PDT
Committed revision 181351.
Comment 4 Myles C. Maxfield 2015-03-10 17:20:42 PDT
Comment on attachment 248366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review

> LayoutTests/editing/selection/extend-by-character-007-expected.txt:16
> +            text run at (14,16) width 275: "\x{D83D}\x{DEA3}\x{D83C}\x{DFFB}\x{D83D}\x{DEA3}\x{D83C}\x{DFFC}\x{D83D}\x{DEA3}\x{D83C}\x{DFFD}\x{D83D}\x{DEA3}\x{D83C}\x{DFFE}\x{D83D}\x{DEA3}\x{D83C}\x{DFFF}\x{D83D}\x{DEA3}"

Does this actually test anything? It looks like this is the same string as in the .html