Bug 142548 – Add support for more emoji with variation

• Component: HTML Editing
• Status: RESOLVED FIXED

[Enrica Casucci]

ICU rules need to be adjusted.

[Enrica Casucci]

Created attachment 248366 [details]
Patch

[Tim Horton]

Comment on attachment 248366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review

> LayoutTests/editing/selection/extend-by-character-007.html:11
> +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>

quotes around the src value, no need for language or type attrs.

> LayoutTests/editing/selection/extend-by-character-007.html:16
> +    for (i = 0; i < 4; i++) {

var i

[Enrica Casucci]

Committed revision 181351.

[Myles C. Maxfield]

Comment on attachment 248366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review

> LayoutTests/editing/selection/extend-by-character-007-expected.txt:16
> +            text run at (14,16) width 275: "\x{D83D}\x{DEA3}\x{D83C}\x{DFFB}\x{D83D}\x{DEA3}\x{D83C}\x{DFFC}\x{D83D}\x{DEA3}\x{D83C}\x{DFFD}\x{D83D}\x{DEA3}\x{D83C}\x{DFFE}\x{D83D}\x{DEA3}\x{D83C}\x{DFFF}\x{D83D}\x{DEA3}"

Does this actually test anything? It looks like this is the same string as in the .html