RESOLVED FIXED 142548
Add support for more emoji with variation 
https://bugs.webkit.org/show_bug.cgi?id=142548
Summary Add support for more emoji with variation
Enrica Casucci
Reported 2015-03-10 15:37:35 PDT
ICU rules need to be adjusted.
Attachments
Patch (6.73 KB, patch)
2015-03-10 15:41 PDT, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2015-03-10 15:41:13 PDT
Created attachment 248366 [details] Patch
Tim Horton
Comment 2 2015-03-10 16:06:10 PDT
Comment on attachment 248366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review > LayoutTests/editing/selection/extend-by-character-007.html:11 > +<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> quotes around the src value, no need for language or type attrs. > LayoutTests/editing/selection/extend-by-character-007.html:16 > + for (i = 0; i < 4; i++) { var i
Enrica Casucci
Comment 3 2015-03-10 16:13:34 PDT
Committed revision 181351.
Myles C. Maxfield
Comment 4 2015-03-10 17:20:42 PDT
Comment on attachment 248366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248366&action=review > LayoutTests/editing/selection/extend-by-character-007-expected.txt:16 > + text run at (14,16) width 275: "\x{D83D}\x{DEA3}\x{D83C}\x{DFFB}\x{D83D}\x{DEA3}\x{D83C}\x{DFFC}\x{D83D}\x{DEA3}\x{D83C}\x{DFFD}\x{D83D}\x{DEA3}\x{D83C}\x{DFFE}\x{D83D}\x{DEA3}\x{D83C}\x{DFFF}\x{D83D}\x{DEA3}" Does this actually test anything? It looks like this is the same string as in the .html
Note You need to log in before you can comment on or make changes to this bug.