Summary: | Rename MediaStreamCenter to RealtimeMediaSourceCenter | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adam.bergkvist, commit-queue, eric.carlson, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 143211 | ||||||||
Attachments: |
|
Description
Philippe Normand
2015-03-10 10:27:08 PDT
Created attachment 248337 [details]
patch
I made very few changes in the GStreamer implementation because I plan
to move it soon anyway along with the OpenWebRTC backend.
Attachment 248337 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:35: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:43: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:36: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:46: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:37: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:32: You should not add a blank line before implementation file's own header. [build/include_order] [4]
Total errors found: 6 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 248338 [details]
patch
Forgot check-webkit-style again :)
Committed r181371: <http://trac.webkit.org/changeset/181371> |