Bug 142529

Summary: [GTK] GL_MAX_VARYING_FLOATS is not defined in OpenGL ES 2
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jdapena, kondapallykalyan, noam, roger_fong, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2015-03-10 03:10:02 PDT 
In GraphicsContext3DOpenGLCommon.cpp is used protected by

#if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2))

but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any other platforms
Comment 1 Zan Dobersek 2015-03-10 03:14:11 PDT 
(In reply to comment #0)
> In GraphicsContext3DOpenGLCommon.cpp is used protected by
> 
> #if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2))
> 
> but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any
> other platforms

PLATFORM(WIN) => (PLATFORM(WIN) || PLATFORM(GTK)) I guess.
Comment 2 Carlos Garcia Campos 2015-03-10 03:17:23 PDT 
(In reply to comment #1)
> (In reply to comment #0)
> > In GraphicsContext3DOpenGLCommon.cpp is used protected by
> > 
> > #if !PLATFORM(IOS) && !(PLATFORM(WIN) && USE(OPENGL_ES_2))
> > 
> > but I don't think GL_MAX_VARYING_FLOATS is available when using GLES2 in any
> > other platforms
> 
> PLATFORM(WIN) => (PLATFORM(WIN) || PLATFORM(GTK)) I guess.

Or simply #if !PLATFORM(IOS) && !USE(OPENGL_ES_2) ?

or am I wrong assuming GL_MAX_VARYING_FLOATS is ot available in OpenGL ES 2?
Comment 3 Carlos Garcia Campos 2015-03-10 03:28:11 PDT 
I'll use PLATFORM(GTK) just in case to avoid breaking EFL
Comment 4 Carlos Garcia Campos 2015-03-10 03:29:45 PDT 
Created attachment 248325 [details]
Patch
Comment 5 Carlos Garcia Campos 2015-03-10 06:27:10 PDT 
Committed r181323: <http://trac.webkit.org/changeset/181323>