Bug 142518

Summary: HashTable::size() should return unsigned integer
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Web Template FrameworkAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2015-03-09 17:56:08 PDT 
Comparing HashSet and Vector sizes exposed the problem that HashSet sizes have been signed since http://trac.webkit.org/changeset/10653
Changing the representation to unsigned makes our int/unsigned usage more consistent.
Comment 1 Alex Christensen 2015-03-09 18:07:52 PDT 
Created attachment 248304 [details]
Patch
Comment 2 Darin Adler 2015-03-10 10:32:58 PDT 
Comment on attachment 248304 [details]
Patch

You should rebase the patch and upload a new one so EWS can chew on it.
Comment 3 Alex Christensen 2015-03-10 12:03:49 PDT 
Created attachment 248343 [details]
Patch
Comment 4 Alex Christensen 2015-03-10 12:20:04 PDT 
Created attachment 248345 [details]
Patch
Comment 5 Alex Christensen 2015-03-10 13:23:54 PDT 
Created attachment 248350 [details]
Patch
Comment 6 Benjamin Poulain 2015-03-10 13:56:04 PDT 
Comment on attachment 248350 [details]
Patch

Nice!
rs=me
Comment 7 WebKit Commit Bot 2015-03-10 14:54:51 PDT 
Comment on attachment 248350 [details]
Patch

Clearing flags on attachment: 248350

Committed r181348: <http://trac.webkit.org/changeset/181348>
Comment 8 WebKit Commit Bot 2015-03-10 14:54:54 PDT 
All reviewed patches have been landed.  Closing bug.