Bug 142518

Summary: HashTable::size() should return unsigned integer
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Web Template FrameworkAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2015-03-09 17:56:08 PDT
Comparing HashSet and Vector sizes exposed the problem that HashSet sizes have been signed since http://trac.webkit.org/changeset/10653 Changing the representation to unsigned makes our int/unsigned usage more consistent.
Attachments
Patch (37.66 KB, patch)
2015-03-09 18:07 PDT, Alex Christensen
no flags
Patch (35.22 KB, patch)
2015-03-10 12:03 PDT, Alex Christensen
no flags
Patch (38.92 KB, patch)
2015-03-10 12:20 PDT, Alex Christensen
no flags
Patch (40.80 KB, patch)
2015-03-10 13:23 PDT, Alex Christensen
no flags
Alex Christensen
Comment 1 2015-03-09 18:07:52 PDT
Darin Adler
Comment 2 2015-03-10 10:32:58 PDT
Comment on attachment 248304 [details] Patch You should rebase the patch and upload a new one so EWS can chew on it.
Alex Christensen
Comment 3 2015-03-10 12:03:49 PDT
Alex Christensen
Comment 4 2015-03-10 12:20:04 PDT
Alex Christensen
Comment 5 2015-03-10 13:23:54 PDT
Benjamin Poulain
Comment 6 2015-03-10 13:56:04 PDT
Comment on attachment 248350 [details] Patch Nice! rs=me
WebKit Commit Bot
Comment 7 2015-03-10 14:54:51 PDT
Comment on attachment 248350 [details] Patch Clearing flags on attachment: 248350 Committed r181348: <http://trac.webkit.org/changeset/181348>
WebKit Commit Bot
Comment 8 2015-03-10 14:54:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.