Bug 142518 - HashTable::size() should return unsigned integer
Summary: HashTable::size() should return unsigned integer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-09 17:56 PDT by Alex Christensen
Modified: 2015-03-10 14:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (37.66 KB, patch)
2015-03-09 18:07 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (35.22 KB, patch)
2015-03-10 12:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (38.92 KB, patch)
2015-03-10 12:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (40.80 KB, patch)
2015-03-10 13:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-03-09 17:56:08 PDT 
Comparing HashSet and Vector sizes exposed the problem that HashSet sizes have been signed since http://trac.webkit.org/changeset/10653
Changing the representation to unsigned makes our int/unsigned usage more consistent.
Comment 1 Alex Christensen 2015-03-09 18:07:52 PDT 
Created attachment 248304 [details]
Patch
Comment 2 Darin Adler 2015-03-10 10:32:58 PDT 
Comment on attachment 248304 [details]
Patch

You should rebase the patch and upload a new one so EWS can chew on it.
Comment 3 Alex Christensen 2015-03-10 12:03:49 PDT 
Created attachment 248343 [details]
Patch
Comment 4 Alex Christensen 2015-03-10 12:20:04 PDT 
Created attachment 248345 [details]
Patch
Comment 5 Alex Christensen 2015-03-10 13:23:54 PDT 
Created attachment 248350 [details]
Patch
Comment 6 Benjamin Poulain 2015-03-10 13:56:04 PDT 
Comment on attachment 248350 [details]
Patch

Nice!
rs=me
Comment 7 WebKit Commit Bot 2015-03-10 14:54:51 PDT 
Comment on attachment 248350 [details]
Patch

Clearing flags on attachment: 248350

Committed r181348: <http://trac.webkit.org/changeset/181348>
Comment 8 WebKit Commit Bot 2015-03-10 14:54:54 PDT 
All reviewed patches have been landed.  Closing bug.