Bug 142496

Summary:

Only call showControls if controls are hidden

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	dino: review+

Description Roger Fong 2015-03-09 10:41:09 PDT

rdar://problem/20083732

Right now we call showControls unconditionally on mousemove, which is very unnecessary.
Only call if if the controls are hidden.

Comment 1 Roger Fong 2015-03-09 10:46:17 PDT

Created attachment 248256 [details]
patch

Comment 2 Dean Jackson 2015-03-09 11:47:58 PDT

Comment on attachment 248256 [details]
patch

All this is a bit dodgy. I'm kind of scared this will break some things :)

Comment 3 Roger Fong 2015-03-09 11:58:56 PDT

Is it? The controlsAreHidden method wasn't working at all in the first place and the only other place it's used is to update the time displays...

Comment 4 Roger Fong 2015-03-09 13:27:10 PDT

http://trac.webkit.org/changeset/181279