Bug 142496

Summary: Only call showControls if controls are hidden
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch dino: review+

Roger Fong
Reported 2015-03-09 10:41:09 PDT
rdar://problem/20083732 Right now we call showControls unconditionally on mousemove, which is very unnecessary. Only call if if the controls are hidden.
Attachments
patch (1.73 KB, patch)
2015-03-09 10:46 PDT, Roger Fong 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2015-03-09 10:46:17 PDT
Created attachment 248256 [details] patch
Dean Jackson
Comment 2 2015-03-09 11:47:58 PDT
Comment on attachment 248256 [details] patch All this is a bit dodgy. I'm kind of scared this will break some things :)
Roger Fong
Comment 3 2015-03-09 11:58:56 PDT
Is it? The controlsAreHidden method wasn't working at all in the first place and the only other place it's used is to update the time displays...
Roger Fong
Comment 4 2015-03-09 13:27:10 PDT
http://trac.webkit.org/changeset/181279
Note You need to log in before you can comment on or make changes to this bug.