Bug 142474

Summary:

Some event handler fixes

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

UI Events

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, kling, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	none
Patch	andersca: review+

Darin Adler

Reported 2015-03-08 23:50:03 PDT

Some event handler fixes

Attachments
Patch (124.17 KB, patch) 2015-03-09 00:04 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (531.90 KB, application/zip) 2015-03-09 00:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (698.14 KB, application/zip) 2015-03-09 01:06 PDT, Build Bot	no flags	Details
Patch (136.74 KB, patch) 2015-03-09 21:48 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (141.58 KB, patch) 2015-03-10 09:28 PDT, Darin Adler	andersca: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2015-03-09 00:04:49 PDT

Created attachment 248232 [details] Patch

Build Bot

Comment 2 2015-03-09 00:59:02 PDT

Comment on attachment 248232 [details] Patch Attachment 248232 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6033706749788160 New failing tests: fast/events/event-attribute.html fast/dom/beforeload/video-before-load.html

Build Bot

Comment 3 2015-03-09 00:59:04 PDT

Created attachment 248233 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-03-09 01:06:53 PDT

Comment on attachment 248232 [details] Patch Attachment 248232 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4833904951296000 New failing tests: fast/events/event-attribute.html fast/dom/beforeload/video-before-load.html

Build Bot

Comment 5 2015-03-09 01:06:55 PDT

Created attachment 248234 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Darin Adler

Comment 6 2015-03-09 21:48:38 PDT

Created attachment 248317 [details] Patch

Darin Adler

Comment 7 2015-03-10 09:08:33 PDT

Comment on attachment 248317 [details] Patch Conditional mechanism in scripts needs some improvement; that will fix GTK and EFL build failures.

Darin Adler

Comment 8 2015-03-10 09:28:07 PDT

Created attachment 248331 [details] Patch

Darin Adler

Comment 9 2015-03-10 10:36:47 PDT

Looks like this is breaking certain gobject bindings in some subtle way. Guess I’ll need to make an attempt at fixing that.

Darin Adler

Comment 10 2015-03-10 19:21:49 PDT

Committed r181358: <http://trac.webkit.org/changeset/181358>

Note You need to log in before you can comment on or make changes to this bug.