Summary: | [SVG -> OTF Converter] x-height cannot be specified | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, jonlee, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Myles C. Maxfield
2015-03-08 15:25:07 PDT
Created attachment 248209 [details]
Patch
Comment on attachment 248209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248209&action=review > LayoutTests/ChangeLog:9 > + For all non-system fonts, OS X disregards the font's reported x-height. Therefore, > + it is impossible to satisfy this test. But is this test not useful for other platforms? (In reply to comment #2) > Comment on attachment 248209 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248209&action=review > > > LayoutTests/ChangeLog:9 > > + For all non-system fonts, OS X disregards the font's reported x-height. Therefore, > > + it is impossible to satisfy this test. > > But is this test not useful for other platforms? I don't think so. The fact that the computed x-height has a particular value if it is unspecified 1. isn't in the spec, and 2. doesn't seem to be valuable. There doesn't seem to be any reason why we should hold ourselves to this particular quality of font-face. *** Bug 140537 has been marked as a duplicate of this bug. *** Comment on attachment 248209 [details] Patch Rejecting attachment 248209 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 248209, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fast/css/ex-unit-with-no-x-height-expected.txt' patching file LayoutTests/fast/css/ex-unit-with-no-x-height.html rm 'LayoutTests/fast/css/ex-unit-with-no-x-height.html' patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1245. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5564885299625984 Committed r181277: <http://trac.webkit.org/changeset/181277> |