Summary: | [iOS Media] Video buffer progress missing on iPhones | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | Media | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2015-03-08 14:44:38 PDT
Created attachment 248205 [details]
Patch
Attachment 248205 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterface.h:50: The parameter name "bufferedTime" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h:74: The parameter name "bufferedTime" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:79: The parameter name "bufferedTime" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r181259: <http://trac.webkit.org/changeset/181259> |