| Summary: | [Mac] Refactor media controls code | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, dino, rniwa | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Eric Carlson
2015-03-08 08:28:12 PDT
Created attachment 248217 [details]
Proposed patch.
Comment on attachment 248217 [details] Proposed patch. Attachment 248217 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5193173596897280 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248219 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 248217 [details] Proposed patch. Attachment 248217 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6530475015274496 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248221 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 248249 [details]
Proposed patch
Comment on attachment 248249 [details] Proposed patch Attachment 248249 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4503798059892736 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248252 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 248249 [details] Proposed patch Attachment 248249 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5667736344592384 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248255 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 248249 [details]
Proposed patch
This looks good to me.
Created attachment 248271 [details]
Patch for the bots.
Comment on attachment 248271 [details] Patch for the bots. Attachment 248271 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6070795403001856 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248276 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 248271 [details] Patch for the bots. Attachment 248271 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5570715180859392 New failing tests: http/tests/media/hls/video-controls-live-stream.html Created attachment 248277 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 248330 [details]
Updated Patch
Created attachment 248349 [details]
Patch for landing.
Comment on attachment 248349 [details] Patch for landing. Clearing flags on attachment: 248349 Committed r181347: <http://trac.webkit.org/changeset/181347> All reviewed patches have been landed. Closing bug. |