Bug 142441

Summary: Don't call RenderLayerCompositor::needsToBeComposited() so many times
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Simon Fraser (smfr) 2015-03-07 11:11:47 PST 
RenderLayerCompositor::needsToBeComposited() is called from ensureBacking(), but RenderLayerCompositor::computeCompositingRequirements() has already computed this. (Also lots of assertions call it).
Comment 1 Simon Fraser (smfr) 2015-03-08 11:26:39 PDT 
Created attachment 248189 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-03-08 11:47:42 PDT 
Created attachment 248192 [details]
Patch
Comment 3 Brent Fulgham 2015-03-08 12:23:28 PDT 
Comment on attachment 248192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248192&action=review

R=me

> Source/WebCore/rendering/RenderLayerCompositor.cpp:953
> +

Should we assert that renderer is non-null for debug builds?
Comment 4 Simon Fraser (smfr) 2015-03-08 15:55:26 PDT 
Comment on attachment 248192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248192&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:953
>> +
> 
> Should we assert that renderer is non-null for debug builds?

We'll crash right away, so I don't think so.
Comment 5 WebKit Commit Bot 2015-03-08 16:39:44 PDT 
Comment on attachment 248192 [details]
Patch

Clearing flags on attachment: 248192

Committed r181247: <http://trac.webkit.org/changeset/181247>
Comment 6 WebKit Commit Bot 2015-03-08 16:39:48 PDT 
All reviewed patches have been landed.  Closing bug.