Bug 142439

Summary: Improve the event handler test
Product: WebKit Reporter: Darin Adler <darin>
Component: UI EventsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
diff of old/new files, created by hand none

Darin Adler
Reported 2015-03-07 09:11:03 PST
Improve the event handler test
Attachments
Patch (226.48 KB, patch)
2015-03-07 09:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
diff of old/new files, created by hand (16.16 KB, patch)
2015-03-07 17:02 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2015-03-07 09:15:02 PST
Created attachment 248155 [details] Patch
Darin Adler
Comment 2 2015-03-07 16:53:37 PST
This is a change just to a test. Small change, mostly rename. Review, anyone?
Ryosuke Niwa
Comment 3 2015-03-07 16:58:02 PST
(In reply to comment #2) > This is a change just to a test. Small change, mostly rename. Review, anyone? Could you post the diff for the test? If you upload it from a subversion checkout (assuming you've used svn mv), it'll actually post the diff for move and the actual diff separately.
Darin Adler
Comment 4 2015-03-07 17:00:32 PST
I don’t have a subversion checkout. I’m annoyed that git doesn’t do this well. Let me post the diff.
Darin Adler
Comment 5 2015-03-07 17:02:51 PST
Created attachment 248168 [details] diff of old/new files, created by hand
Darin Adler
Comment 6 2015-03-07 17:03:10 PST
OK, posted it now.
WebKit Commit Bot
Comment 7 2015-03-07 18:14:50 PST
Comment on attachment 248155 [details] Patch Clearing flags on attachment: 248155 Committed r181217: <http://trac.webkit.org/changeset/181217>
WebKit Commit Bot
Comment 8 2015-03-07 18:14:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.